From 6fa826baa2ba0a371fd369c140fa20e12982ef7e Mon Sep 17 00:00:00 2001 From: Adam <897017+aSemy@users.noreply.github.com> Date: Sun, 17 Jul 2022 23:55:58 +0200 Subject: [PATCH] return 304 if a tile doesn't exist (nicer than having the browser spammed with errors) --- .../server/web/rest/factorioServersRoutes.kt | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/modules/events-server/src/main/kotlin/dev/adamko/kafkatorio/server/web/rest/factorioServersRoutes.kt b/modules/events-server/src/main/kotlin/dev/adamko/kafkatorio/server/web/rest/factorioServersRoutes.kt index 1a42e16..283d767 100644 --- a/modules/events-server/src/main/kotlin/dev/adamko/kafkatorio/server/web/rest/factorioServersRoutes.kt +++ b/modules/events-server/src/main/kotlin/dev/adamko/kafkatorio/server/web/rest/factorioServersRoutes.kt @@ -61,20 +61,9 @@ private suspend fun PipelineContext.handleTileRequest( ) } } else { - call.respond(HttpStatusCode.NotFound) -// // It's not a client error to request this tile, it just doesn't exist (yet). So return 304? -// call.response.cacheControl(CacheControl.NoStore(null)) -// -// HeadersBuilder(size = 2).apply { -// EntityTagVersion(System.currentTimeMillis().hashCode().toString()) -// .appendHeadersTo(this) -// LastModifiedVersion(System.currentTimeMillis()) -// .appendHeadersTo(this) -// }.build().flattenForEach { name, value -> -// call.response.header(name, value) -// } -// -// call.respond(HttpStatusCode.NotModified) + // It's not a client or server error to request a non-existent tile, it just doesn't exist + // (yet). So return 304. + call.respond(HttpStatusCode.NotModified) } }