From 0b7e30af30ab03b6cf45ae47f2dd8c262b609834 Mon Sep 17 00:00:00 2001 From: Sophie Herold Date: Tue, 5 Dec 2023 23:32:35 +0100 Subject: [PATCH] image: Fix setting horizontal instead of vertical Fix horizontal scrollbar sometimes jumping to center while zooming in. --- NEWS | 5 +++++ data/org.gnome.Loupe.metainfo.xml.in.in | 7 +++++++ src/widgets/image.rs | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 19c9fb8..5dd470a 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,8 @@ +45.3 +==== + +- Fix horizontal scrollbar sometimes jumping to center while zooming in + 45.2 ==== diff --git a/data/org.gnome.Loupe.metainfo.xml.in.in b/data/org.gnome.Loupe.metainfo.xml.in.in index 5dc0e36..8254ec7 100644 --- a/data/org.gnome.Loupe.metainfo.xml.in.in +++ b/data/org.gnome.Loupe.metainfo.xml.in.in @@ -66,6 +66,13 @@ + + +
    +
  • Zooming into wide images can no longer cause the horizontal scrollbar to suddenly jump into the center position.
  • +
+
+
    diff --git a/src/widgets/image.rs b/src/widgets/image.rs index 12bd848..924fdce 100644 --- a/src/widgets/image.rs +++ b/src/widgets/image.rs @@ -1426,7 +1426,7 @@ impl LpImage { let target_vborder = self.widget_height() - self.image_size().1 as f64 * zoom; self.imp() - .zoom_hscrollbar_transition + .zoom_vscrollbar_transition .set(current_vborder.signum() != target_vborder.signum() && current_vborder != 0.); let animation = self.zoom_animation();