From 307c864c6e1f57322729f7ca04758796ff90d84e Mon Sep 17 00:00:00 2001
From: Sophie Herold <sophie@hemio.de>
Date: Thu, 30 Nov 2023 01:20:13 +0100
Subject: [PATCH] window: Copy metadata instead of image if selected

---
 data/resources/gtk/help-overlay.ui |  7 +++---
 src/widgets/image_page.ui          |  2 +-
 src/window.rs                      | 37 ++++++++++++++++++++++++++----
 src/window.ui                      |  2 +-
 4 files changed, 38 insertions(+), 10 deletions(-)

diff --git a/data/resources/gtk/help-overlay.ui b/data/resources/gtk/help-overlay.ui
index 96fb62c..df55e2f 100644
--- a/data/resources/gtk/help-overlay.ui
+++ b/data/resources/gtk/help-overlay.ui
@@ -17,8 +17,8 @@
             </child>
             <child>
               <object class="GtkShortcutsShortcut">
-                <property name="title" translatable="yes" context="shortcut window">Copy Image to Clipboard</property>
-                <property name="action-name">win.copy</property>
+                <property name="title" translatable="yes" context="shortcut window">Copy Image or Metadata to Clipboard</property>
+                <property name="accelerator">&lt;Ctrl&gt;C</property>
               </object>
             </child>
             <child>
@@ -269,5 +269,4 @@
       </object>
     </child>
   </object>
-</interface>
-
+</interface>
\ No newline at end of file
diff --git a/src/widgets/image_page.ui b/src/widgets/image_page.ui
index ae135ed..4030005 100644
--- a/src/widgets/image_page.ui
+++ b/src/widgets/image_page.ui
@@ -16,7 +16,7 @@
       </item>
       <item>
         <attribute name="label" translatable="yes">_Copy</attribute>
-        <attribute name="action">win.copy</attribute>
+        <attribute name="action">win.copy-image</attribute>
       </item>
     </section>
     <section>
diff --git a/src/window.rs b/src/window.rs
index 7eace35..76dc81a 100644
--- a/src/window.rs
+++ b/src/window.rs
@@ -122,6 +122,21 @@ mod imp {
             Self::bind_template(klass);
             Self::Type::bind_template_callbacks(klass);
 
+            klass.add_binding(
+                gdk::Key::c,
+                gdk::ModifierType::CONTROL_MASK,
+                |window, _| {
+                    if window.has_metadata_selected() {
+                        // Pass on to normal copy handler to copy selected metadata
+                        false
+                    } else {
+                        window.copy_image();
+                        true
+                    }
+                },
+                None,
+            );
+
             // Set up actions
             klass.install_action("win.toggle-fullscreen", None, move |win, _, _| {
                 win.toggle_fullscreen(!win.is_fullscreened());
@@ -225,8 +240,8 @@ mod imp {
                 win.print();
             });
 
-            klass.install_action("win.copy", None, move |win, _, _| {
-                win.copy();
+            klass.install_action("win.copy-image", None, move |win, _, _| {
+                win.copy_image();
             });
 
             klass.install_action_async("win.trash", None, |win, _, _| async move {
@@ -561,7 +576,21 @@ impl LpWindow {
         }
     }
 
-    fn copy(&self) {
+    /// Returns true if some text in metadata is currently selected
+    fn has_metadata_selected(&self) -> bool {
+        if let Some(focus_widget) = self.focus_widget() {
+            if focus_widget.is_ancestor(&*self.imp().properties_view) {
+                if let Ok(label) = focus_widget.downcast::<gtk::Label>() {
+                    return label.selection_bounds().is_some();
+                }
+            }
+        }
+
+        false
+    }
+
+    /// Copy image to clipboard or metadata text if selected
+    fn copy_image(&self) {
         let imp = self.imp();
 
         if let Err(e) = imp.image_view.copy() {
@@ -685,7 +714,7 @@ impl LpWindow {
         self.action_set_enabled("win.print", enabled);
         self.action_set_enabled("win.rotate_cw", enabled);
         self.action_set_enabled("win.rotate_ccw", enabled);
-        self.action_set_enabled("win.copy", enabled);
+        self.action_set_enabled("win.copy-image", enabled);
         self.action_set_enabled("win.zoom-best-fit", enabled);
         self.action_set_enabled("win.zoom-to-exact", enabled);
         self.action_set_enabled("win.toggle-properties", enabled);
diff --git a/src/window.ui b/src/window.ui
index f9f44e4..f7e305f 100644
--- a/src/window.ui
+++ b/src/window.ui
@@ -105,7 +105,7 @@
             <child type="start">
               <object class="GtkButton">
                 <property name="icon-name">edit-copy-symbolic</property>
-                <property name="action-name">win.copy</property>
+                <property name="action-name">win.copy-image</property>
                 <property name="tooltip-text" translatable="yes">Copy to Clipboard</property>
               </object>
             </child>