lazzexus/Loupe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

image_window: Don't rely on root existing

Browse source 
This fixes a single case of root being access from the control hide
animation. Apparently it's possible that the widget is unparented from
the window and unmaped but not yet unrefed?

Fixes #473
This commit is contained in:
Sophie Herold 2025-03-29 20:51:30 +01:00
parent 0b4db9e03f
commit 5055eddda0
3 changed files with 32 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/util/root.rs
View file

@ -24,12 +24,28 @@ pub trait ParentWindow: WidgetExt {
let result = self.root().and_downcast();
if result.is_none() {
log::error!("Couldn't find LpWindow for {self:?}");
log::error!(
"Couldn't find LpWindow for {self:?}. mapped={}",
self.is_mapped()
);
}
result.unwrap()
}
fn try_window(&self) -> Option<LpWindow> {
let result = self.root().and_downcast();
if result.is_none() {
log::debug!(
"Couldn't find LpWindow for {self:?}. mapped={}",
self.is_mapped()
);
}
result
}
fn edit_window(&self) -> LpEditWindow {
let parent = self.parent().unwrap();