From 8983f6155880042bb434da0c4e2fb827f20521e0 Mon Sep 17 00:00:00 2001
From: Sophie Herold <sophie@hemio.de>
Date: Wed, 5 Mar 2025 23:31:39 +0100
Subject: [PATCH] edit/crop: Select correct orientation on open

Closes #468
---
 .../fixed-edit-crop-pre-select-portrait-orientation |  1 +
 src/widgets/edit/crop.rs                            | 13 ++++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)
 create mode 100644 news.d/48.0/fixed-edit-crop-pre-select-portrait-orientation

diff --git a/news.d/48.0/fixed-edit-crop-pre-select-portrait-orientation b/news.d/48.0/fixed-edit-crop-pre-select-portrait-orientation
new file mode 100644
index 0000000..d6fcd55
--- /dev/null
+++ b/news.d/48.0/fixed-edit-crop-pre-select-portrait-orientation
@@ -0,0 +1 @@
+edit/crop: Pre-select the portrait orientation for image that are taller than wide.
diff --git a/src/widgets/edit/crop.rs b/src/widgets/edit/crop.rs
index 8ecac7b..c71c33a 100644
--- a/src/widgets/edit/crop.rs
+++ b/src/widgets/edit/crop.rs
@@ -206,8 +206,6 @@ mod imp {
                     obj.imp().asepect_ratio_orientation_changed();
                 }
             ));
-
-            self.asepect_ratio_orientation_changed();
         }
 
         fn dispose(&self) {
@@ -215,7 +213,15 @@ mod imp {
         }
     }
 
-    impl WidgetImpl for LpEditCrop {}
+    impl WidgetImpl for LpEditCrop {
+        fn root(&self) {
+            self.parent_root();
+            let obj = self.obj();
+
+            // Select correct orientation based on aspect ratio
+            obj.handle_error(self.apply_reset());
+        }
+    }
     impl BinImpl for LpEditCrop {}
 
     impl LpEditCrop {
@@ -281,6 +287,7 @@ mod imp {
             } else {
                 LpOrientation::Landscape
             };
+            dbg!("setting to", orientation);
             let res = self
                 .obj()
                 .activate_action("edit-crop.orientation", Some(&orientation.to_variant()));