lazzexus/Loupe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

image_view: Load images once

Browse source 
We don't need to load the file twice just to get the
dimensions. We can load a GdkTexture, use it's APIs
for the width and height, and return that as a result
to the window. This allows us to kill the `dimensions-loaded`
signal and one of the places where we need to load a file.
This commit is contained in:
Christopher Davis 2021-09-28 22:08:57 -07:00
parent e0820e0881
commit 945aff3029
2 changed files with 31 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/window.rs
View file

@ -134,12 +134,6 @@ mod imp {
obj.pick_file();
}));
self.image_view.connect_dimensions_loaded(
clone!(@weak obj => move |_, width, height| {
obj.resize_from_dimensions(width, height);
}),
);
// Property bindings didn't seem to work here
self.image_view.connect_notify_local(
Some("filename"),
@ -259,12 +253,15 @@ impl IvWindow {
let imp = imp::IvWindow::from_instance(self);
log::debug!("Loading file: {}", file.uri().to_string());
imp.image_view.set_image_from_file(file);
imp.stack.set_visible_child(&*imp.image_view);
imp.image_view.grab_focus();
self.set_actions_enabled(true);
match imp.image_view.set_image_from_file(file) {
Ok((width, height)) => {
self.resize_from_dimensions(width, height);
imp.stack.set_visible_child(&*imp.image_view);
imp.image_view.grab_focus();
self.set_actions_enabled(true)
}
Err(e) => log::error!("Could not load file: {}", e.to_string()),
}
}
pub fn set_actions_enabled(&self, enabled: bool) {