lazzexus/Loupe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

window: Don't store window to avoid ref cycles

Browse source 
Use root() instead and move one constructor to on root for having the
root available.
This commit is contained in:
Sophie Herold 2024-12-18 17:12:17 +01:00
parent 8345640757
commit b9f22ebfc3
12 changed files with 77 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/widgets/edit_window.rs
View file

@ -23,14 +23,14 @@ use adw::subclass::prelude::*;
use glycin::Operations;
use super::edit::LpEditCrop;
use super::{LpImage, LpWindow};
use super::LpImage;
use crate::deps::*;
use crate::util::gettext::*;
use crate::util::root::ParentWindow;
use crate::util::ErrorType;
mod imp {
use super::*;
use crate::widgets::error_details::ErrorType;
#[derive(Debug, Default, gtk::CompositeTemplate, glib::Properties)]
#[properties(wrapper_type = super::LpEditWindow)]
@ -43,8 +43,6 @@ mod imp {
#[template_child]
save: TemplateChild<gtk::Button>,
#[property(get, construct_only)]
window: OnceCell<LpWindow>,
#[property(get, construct_only)]
original_image: OnceCell<LpImage>,
@ -170,9 +168,8 @@ glib::wrapper! {
}
impl LpEditWindow {
pub fn new(window: LpWindow, image: LpImage) -> Self {
pub fn new(image: LpImage) -> Self {
glib::Object::builder()
.property("window", window)
.property("original_image", image)
.build()
}