lazzexus/Loupe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

window: Don't store window to avoid ref cycles

Browse source 
Use root() instead and move one constructor to on root for having the
root available.
This commit is contained in:
Sophie Herold 2024-12-18 17:12:17 +01:00
parent 8345640757
commit b9f22ebfc3
12 changed files with 77 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/widgets/image_page.rs
View file

@ -29,6 +29,7 @@ use super::LpErrorDetails;
use crate::decoder::DecoderError;
use crate::deps::*;
use crate::util::gettext::*;
use crate::util::ErrorType;
use crate::widgets::LpImage;
mod imp {
@ -255,11 +256,7 @@ impl LpImagePage {
#[weak(rename_to = obj)]
self,
move |_| {
LpErrorDetails::new(
&obj.root().unwrap(),
&err,
super::error_details::ErrorType::Loader,
);
LpErrorDetails::new(&obj.root().unwrap(), &err, ErrorType::Loader);
}
));
}
@ -271,11 +268,7 @@ impl LpImagePage {
#[weak(rename_to = obj)]
self,
move |_| {
LpErrorDetails::new(
&obj.root().unwrap(),
&err,
super::error_details::ErrorType::Loader,
);
LpErrorDetails::new(&obj.root().unwrap(), &err, ErrorType::Loader);
}
));