refactor: Use is_some_and

This commit is contained in:
FineFindus 2023-06-26 11:59:17 +00:00 • committed by Sophie Herold
parent 1a39751402
commit bc9aff5068
5 changed files with 33 additions and 33 deletions

View file

@ -653,15 +653,18 @@ impl FrameBufferExt for ArcSwap<FrameBuffer> {
}
fn frame_timeout(&self, elapsed: Duration) -> bool {
if let Some(next_frame) = self.load().images.get(1) {
if elapsed >= next_frame.delay {
self.rcu(|tiling_store| {
let mut new_store = (**tiling_store).clone();
new_store.images.pop_front();
Arc::new(new_store)
});
return true;
}
if self
.load()
.images
.get(1)
.is_some_and(|next_frame| elapsed >= next_frame.delay)
{
self.rcu(|tiling_store| {
let mut new_store = (**tiling_store).clone();
new_store.images.pop_front();
Arc::new(new_store)
});
return true;
}
false

View file

@ -81,10 +81,8 @@ impl GPSCoord {
}
}
if let Some(min_) = min {
if deg.denom > 1 && min_.num == 0 {
min = None;
}
if min.is_some_and(|min_| deg.denom > 1 && min_.num == 0) {
min = None;
}
Some((

View file

@ -142,10 +142,12 @@ impl ImageMetadata {
}
pub fn f_number(&self) -> Option<String> {
if let Some(exif) = &self.exif {
if let Some(field) = exif.get_field(exif::Tag::FNumber, exif::In::PRIMARY) {
return Some(format!("ƒ\u{2215}{}", field.display_value()));
}
if let Some(field) = self
.exif
.as_ref()
.and_then(|exif| exif.get_field(exif::Tag::FNumber, exif::In::PRIMARY))
{
return Some(format!("ƒ\u{2215}{}", field.display_value()));
}
None

View file

@ -345,10 +345,11 @@ impl LpImageView {
fn navigate_to_file(&self, new_file: &gio::File) {
let sliding_view = self.sliding_view();
if let Some(current_file) = self.current_file() {
if new_file.equal(&current_file) {
return;
}
if self
.current_file()
.is_some_and(|current_file| current_file.equal(new_file))
{
return;
}
let Some(new_index) = self.model().index_of(new_file) else {

View file

@ -699,13 +699,11 @@ impl LpWindow {
.current_page()
.map(|page| page.image());
if let Some(image) = image {
if image.image_size() > (0, 0) {
log::debug!("Showing window because image size is ready");
// this let's the window determine the default size from LpImage's natural size
self.set_default_size(-1, -1);
self.present();
}
if image.is_some_and(|img| img.image_size() > (0, 0)) {
log::debug!("Showing window because image size is ready");
// this let's the window determine the default size from LpImage's natural size
self.set_default_size(-1, -1);
self.present();
}
}
@ -716,11 +714,9 @@ impl LpWindow {
let current_page = self.imp().image_view.current_page();
if let Some(page) = current_page {
if page.image().error().is_some() {
log::debug!("Showing window because loading image failed");
self.present();
}
if current_page.is_some_and(|page| page.image().error().is_some()) {
log::debug!("Showing window because loading image failed");
self.present();
}
}