refactor: Use is_some_and

src/decoder/tiling.rs

@@ -653,15 +653,18 @@ impl FrameBufferExt for ArcSwap<FrameBuffer> {
     }
 
     fn frame_timeout(&self, elapsed: Duration) -> bool {
-        if let Some(next_frame) = self.load().images.get(1) {
+        if self
-            if elapsed >= next_frame.delay {
+            .load()
-                self.rcu(|tiling_store| {
+            .images
-                    let mut new_store = (**tiling_store).clone();
+            .get(1)
-                    new_store.images.pop_front();
+            .is_some_and(|next_frame| elapsed >= next_frame.delay)
-                    Arc::new(new_store)
+        {
-                });
+            self.rcu(|tiling_store| {
-                return true;
+                let mut new_store = (**tiling_store).clone();
-            }
+                new_store.images.pop_front();
+                Arc::new(new_store)
+            });
+            return true;
         }
 
         false

src/image_metadata/gps.rs

@@ -81,10 +81,8 @@ impl GPSCoord {
             }
         }
 
-        if let Some(min_) = min {
+        if min.is_some_and(|min_| deg.denom > 1 && min_.num == 0) {
-            if deg.denom > 1 && min_.num == 0 {
+            min = None;
-                min = None;
-            }
         }
 
         Some((

src/image_metadata/mod.rs

@@ -142,10 +142,12 @@ impl ImageMetadata {
     }
 
     pub fn f_number(&self) -> Option<String> {
-        if let Some(exif) = &self.exif {
+        if let Some(field) = self
-            if let Some(field) = exif.get_field(exif::Tag::FNumber, exif::In::PRIMARY) {
+            .exif
-                return Some(format!("ƒ\u{2215}{}", field.display_value()));
+            .as_ref()
-            }
+            .and_then(|exif| exif.get_field(exif::Tag::FNumber, exif::In::PRIMARY))
+        {
+            return Some(format!("ƒ\u{2215}{}", field.display_value()));
         }
 
         None

src/widgets/image_view.rs

@@ -345,10 +345,11 @@ impl LpImageView {
     fn navigate_to_file(&self, new_file: &gio::File) {
         let sliding_view = self.sliding_view();
 
-        if let Some(current_file) = self.current_file() {
+        if self
-            if new_file.equal(&current_file) {
+            .current_file()
-                return;
+            .is_some_and(|current_file| current_file.equal(new_file))
-            }
+        {
+            return;
         }
 
         let Some(new_index) = self.model().index_of(new_file) else {

src/window.rs

@@ -699,13 +699,11 @@ impl LpWindow {
             .current_page()
             .map(|page| page.image());
 
-        if let Some(image) = image {
+        if image.is_some_and(|img| img.image_size() > (0, 0)) {
-            if image.image_size() > (0, 0) {
+            log::debug!("Showing window because image size is ready");
-                log::debug!("Showing window because image size is ready");
+            // this let's the window determine the default size from LpImage's natural size
-                // this let's the window determine the default size from LpImage's natural size
+            self.set_default_size(-1, -1);
-                self.set_default_size(-1, -1);
+            self.present();
-                self.present();
-            }
         }
     }
 
@@ -716,11 +714,9 @@ impl LpWindow {
 
         let current_page = self.imp().image_view.current_page();
 
-        if let Some(page) = current_page {
+        if current_page.is_some_and(|page| page.image().error().is_some()) {
-            if page.image().error().is_some() {
+            log::debug!("Showing window because loading image failed");
-                log::debug!("Showing window because loading image failed");
+            self.present();
-                self.present();
-            }
         }
     }