lazzexus/Loupe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

application: Call style_manager from startup

Browse source 
It was called from app constructed before. That's too early since since
GTK/Adw is not initialized yet. This is treated as an error in GTK
4.17.0 and terminates the app on startup.

Closes #423
This commit is contained in:
Sophie Herold 2024-11-11 17:05:37 +01:00
parent 8bcf89ba00
commit c5c2dce069
2 changed files with 7 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
news.d/47.2/fixed-call-style-manager-too-early Normal file
View file

@ -0,0 +1 @@
Don't call style manager in application constructor since this is too early. Do it in startup instead. Without this fix, GTK 4.17.0 will terminate the app on startup.

12
src/application.rs
View file

@ -56,27 +56,27 @@ mod imp {
type ParentType = adw::Application; type ParentType = adw::Application;
} }
// Overrides GObject vfuncs
impl ObjectImpl for LpApplication { impl ObjectImpl for LpApplication {
fn constructed(&self) { fn constructed(&self) {
let obj = self.obj(); let obj = self.obj();
self.parent_constructed(); self.parent_constructed();
// Force dark theme
obj.style_manager()
.set_color_scheme(adw::ColorScheme::PreferDark);
// Set up the actions // Set up the actions
obj.setup_actions(); obj.setup_actions();
} }
} }
// Overrides GApplication vfuncs
impl ApplicationImpl for LpApplication { impl ApplicationImpl for LpApplication {
fn startup(&self) { fn startup(&self) {
log::trace!("Startup"); log::trace!("Startup");
self.parent_startup(); self.parent_startup();
// Force dark theme
self.obj()
.style_manager()
.set_color_scheme(adw::ColorScheme::PreferDark);
LpShyBin::ensure_type(); LpShyBin::ensure_type();
gtk::Window::set_default_icon_name(config::APP_ID); gtk::Window::set_default_icon_name(config::APP_ID);
} }