Sophie Herold
ea449046b8
edit_window: Don't quit if close_request saving fails
...
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/576 >
2026-06-22 19:07:41 +00:00
Sophie Herold
da60453335
edit_window: Let the save changes text make sense
...
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/576 >
2026-06-22 19:07:41 +00:00
Sophie Herold
6b4d057167
Trigger save dialog via close_request
...
This simplifies the code and fixes that unsaved changes were only saved
for the active window and dropped for all others.
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/576 >
2026-06-22 19:07:41 +00:00
Abhinandan Thakur
eb4e5c469a
Changed the logic of app.quit accelerator, introduced a dialog in it.
...
Also made functions such is_save_senstive() and save_overwrite()
publicly accessible for logic building.
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/576 >
2026-06-22 19:07:40 +00:00
Abhinandan Thakur
f2d4fa6e0d
Save-Dialog: Added a Save Dialog for Ctrl+Q Unsaved Changes
...
Changed the logic of app.quit accelerator, introduced a dialog in it.
Also made functions such is_save_senstive() and save_overwrite()
publicly accessible for logic building.
Fixes : #537
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/576 >
2026-06-22 19:07:40 +00:00
Sophie Herold
19e0fd7c6e
Update copyright comments
2026-02-27 21:03:02 +01:00
Maximiliano Sandoval
d922a033ec
edit_window: Remove i==1 branch for ngettext
...
A message catalog can have at most a single string with a given msgid,
in this case having a branch with gettext and another with ngettext
would result in two strings with " (Edited)" as their msgid.
This can be checked via:
$ meson compile loupe-pot
INFO: autodetecting backend as ninja
INFO: calculating backend command to run: /usr/bin/ninja loupe-pot
[0/1] Running external command loupe-pot
/usr/bin/xgettext: warning: msgid ' (Edited)' is used without plural and with plural.
src/widgets/edit_window.rs:197: Here is the occurrence without plural.
src/widgets/edit_window.rs:200: Here is the occurrence with plural.
Workaround: If the msgid is a sentence, change the wording of the sentence; otherwise, use contexts for disambiguation.
Part-of: <https://gitlab.gnome.org/GNOME/loupe/-/merge_requests/578 >
2026-01-29 23:14:58 +00:00
Sophie Herold
8972c5efb9
code: Use chained if-let's
2026-01-29 23:59:58 +01:00
Sophie Herold
4d6d771ab4
Use tracing for logging
2025-12-18 23:15:46 +01:00
Sophie Herold
83b2c7cae1
util/root: Add window_show_error() to avoid unwrap
...
Fixes #553
2025-12-09 22:07:30 +01:00
Sophie Herold
4439499cda
code: Reformat with Rust 2024 edition
2025-12-04 06:17:55 +01:00
Sophie Herold
246c4a6bcc
editing: Correctly detect if trash is supported
...
Don't activate "Replace Original" action, if trashing of the original
file is not supported.
Closes #509
2025-10-21 22:49:54 +02:00
Sophie Herold
0e6ddb0227
Add missing implementations
2025-08-22 15:03:55 +02:00
Sophie Herold
b3d972c5c3
Update to glycin 2.0 alpha.7
2025-07-07 22:18:36 +02:00
Sophie Herold
ef5f94859b
editing: Fix preroateted images
...
Editing does not work correctly if PNGs or JPEGs are already rotated via
an Exif orientation entry before editing. This needs the glycin-image-rs
1.2.1 loader to work correctly.
Closes #481
2025-04-11 14:48:50 +02:00
Sophie Herold
7d3cdb93b9
edit_window: Don't show error for canceled loader
2025-02-13 22:43:03 +01:00
Sophie Herold
bb72324a64
error_details: Set description instead of title
2025-02-13 22:08:13 +01:00
Sophie Herold
828306c206
edit_window: Handle CancellableFuture errors
...
Ignore the cancellation and instead check for actual errors inside an
uncanceled operation.
2025-02-13 14:54:40 +01:00
Sophie Herold
b2e626091f
edit_window: Fix new filename detection
2025-01-31 20:12:35 +01:00
Sophie Herold
06a8474207
edit: Disable save actions
2025-01-31 14:01:33 +01:00
Sophie Herold
8bb6f8da88
edit_window: Add save and cancel shortcuts
2025-01-31 13:49:39 +01:00
Sophie Herold
5706b2eaeb
edit: Stop saving operation on using "Cancel"
2025-01-29 14:25:19 +01:00
Sophie Herold
51883734f5
edit/crop: Enable reset and save on selection change
2025-01-29 00:20:03 +01:00
Sophie Herold
9fbe091f1a
edit: Use filename with (Edited) suffix for "Save As"
2025-01-28 23:45:46 +01:00
Sophie Herold
40d425ac80
edit: Visual feedback while saving image
...
Closes #441
2025-01-22 20:49:19 +01:00
Sophie Herold
729f5249ed
edit/crop: Apply crop on save
2025-01-22 15:10:16 +00:00
Sophie Herold
e4bb97140a
edit_window: Return to image view after saving
2025-01-17 12:35:43 +01:00
Sophie Herold
8d3c9d70e7
image_view: Don't rely on LpImage signals
2025-01-17 01:32:41 +01:00
Sophie Herold
0a3a6efa02
edit_window: Always use .suggested-action style
2025-01-16 12:18:52 +01:00
Sophie Herold
bbc61a3215
edit_window: Disable "Done" if image is unchanged
2025-01-15 21:29:47 +00:00
Sophie Herold
84e58f28df
edit_window: Add "Replace Original" option
2025-01-15 21:29:47 +00:00
Sophie Herold
507b7b24f9
edit_window: Add "Done" menu replacing "Save" button
2025-01-15 21:29:47 +00:00
Sophie Herold
bbf9534bdd
editing: Only enable editing action if available
2024-12-22 20:27:33 +01:00
Sophie Herold
b9f22ebfc3
window: Don't store window to avoid ref cycles
...
Use root() instead and move one constructor to on root for having the
root available.
2024-12-22 20:27:33 +01:00
Sophie Herold
8345640757
editing: Handle errors
2024-12-22 20:27:33 +01:00
Sophie Herold
5b51237203
editing: Add error handling for saving files
2024-12-22 20:27:33 +01:00
Sophie Herold
3f82a5f435
window: Fix arrow key bindings not working
...
The actions for global accels have to be at window level.
2024-12-22 20:27:33 +01:00
Sophie Herold
05dbee6a0b
editing: Add save edited file
2024-12-22 20:27:33 +01:00
Sophie Herold
b6bdc9398d
edit: Add Cancel button
2024-12-22 20:27:33 +01:00
Sophie Herold
6867e0b13f
Add cropping
2024-12-22 20:27:33 +01:00
Sophie Herold
f5660ba83e
widgets: Rename Window* to *Window
2024-12-22 20:27:33 +01:00
