2aa480eee5
Previously we loaded images synchronously and manually changed `LpImage`. This could cause freezes when loading large images and SVGs. We also had no proper feedback for when a corrupted or unsupported image was loaded. This commit introduces a major rework to how we handle images and the gallery. It introduces a swipeable gallery that loads files asynchronously via a new widget: LpImagePage. LpImagePage owns the file and information related to the file, and on creation it spawns a future that either loads an error page when it can't load something (file deleted, corrupted, or unsupported) or the actual image via LpImage. LpImagePage now holds the right-click popover and the associated gestures. The gestures needed to be moved to LpImagePage in order to rework LpImageView's overlay - instead of having an overlay child that's a box with a few buttons, we now have the buttons as individual overlay children. This could cause them to overlap each other at certain sizes, but it's required in order to allow input to reach the carousel below. Right now this comes with a few regressions: * Occasionally input gets blocked across the applications. It's hard to tell if this is caused by swipes or right clicking. This input issue can cause a crash - no Rust backtrace, so a debugger is needed. * The "current" page doesn't seem to be properly loaded by the time `set_image_from_file ()` finishes, so we need to rework resizing from image dimensions * We need to re-implement loading different directories and files within directories There also seems to be an issue on touchscreens, swiping between images on a touchscreen causes responsiveness issues not present when swiping on a touchpad. My guess is that it's related to the long press gesture.
76 lines
2.9 KiB
XML
76 lines
2.9 KiB
XML
<?xml version="1.0" encoding="UTF-8"?>
|
|
<interface>
|
|
<template class="LpImagePage" parent="AdwBin">
|
|
<property name="hexpand">True</property>
|
|
<property name="vexpand">True</property>
|
|
<property name="child">
|
|
<object class="GtkStack" id="stack">
|
|
<property name="transition-type">crossfade</property>
|
|
<child>
|
|
<object class="GtkSpinner" id="spinner">
|
|
<property name="halign">center</property>
|
|
<property name="valign">center</property>
|
|
<property name="spinning">True</property>
|
|
</object>
|
|
</child>
|
|
<child>
|
|
<object class="AdwStatusPage" id="error_page">
|
|
<property name="icon-name">image-missing-symbolic</property>
|
|
<property name="title" translatable="yes">Could not Load Image</property>
|
|
<property name="description" translatable="yes">This image could be corrupted or may use an unsupported file format.</property>
|
|
</object>
|
|
</child>
|
|
<child>
|
|
<object class="LpImage" id="image">
|
|
<property name="halign">center</property>
|
|
<property name="valign">center</property>
|
|
<child>
|
|
<object class="GtkGestureClick" id="click_gesture">
|
|
<property name="button">3</property>
|
|
</object>
|
|
</child>
|
|
<child>
|
|
<object class="GtkGestureLongPress" id="press_gesture">
|
|
<property name="touch-only">True</property>
|
|
</object>
|
|
</child>
|
|
<child>
|
|
<object class="GtkPopoverMenu" id="popover">
|
|
<property name="has-arrow">False</property>
|
|
<property name="menu-model">image_menu</property>
|
|
</object>
|
|
</child>
|
|
</object>
|
|
</child>
|
|
</object>
|
|
</property>
|
|
</template>
|
|
<menu id="image_menu">
|
|
<section>
|
|
<item>
|
|
<attribute name="label" translatable="yes">_Open With…</attribute>
|
|
<attribute name="action">win.open-with</attribute>
|
|
</item>
|
|
<!--<item>
|
|
<attribute name="label" translatable="yes">_Display On…</attribute>
|
|
<attribute name="action">win.display-on</attribute>
|
|
</item>-->
|
|
<item>
|
|
<attribute name="label" translatable="yes">_Print…</attribute>
|
|
<attribute name="action">win.print</attribute>
|
|
</item>
|
|
<item>
|
|
<attribute name="label" translatable="yes">_Copy</attribute>
|
|
<attribute name="action">win.copy</attribute>
|
|
</item>
|
|
<!--<item>
|
|
<attribute name="label" translatable="yes">_Rotate</attribute>
|
|
<attribute name="action">win.rotate-image</attribute>
|
|
</item>-->
|
|
<item>
|
|
<attribute name="label" translatable="yes">_Set as Wallpaper</attribute>
|
|
<attribute name="action">win.set-wallpaper</attribute>
|
|
</item>
|
|
</section>
|
|
</menu>
|
|
</interface>
|