From d14dccd8b8362348c922d6ea3f94282191ae5a2c Mon Sep 17 00:00:00 2001
From: rope <fredrik@nordhammer.it>
Date: Thu, 10 Sep 2026 09:52:44 +0100
Subject: [PATCH] =?UTF-8?q?zen:=20correct=20the=20color-scheme=20comment?=
 =?UTF-8?q?=20=E2=80=94=20it's=20light-dark(),=20not=20system=20colours?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---
 templates/zen-userChrome.css | 22 ++++++++++++++++------
 1 file changed, 16 insertions(+), 6 deletions(-)

diff --git a/templates/zen-userChrome.css b/templates/zen-userChrome.css
index 7f5eafb..30e988d 100644
--- a/templates/zen-userChrome.css
+++ b/templates/zen-userChrome.css
@@ -114,12 +114,22 @@
   --toolbox-textcolor: {{colors.on_surface.default.hex}} !important;
 }
 
-/* Menus and dropdowns (context menus, <select>, urlbar results) take their
-   text from Gecko's system colours (-moz-MenuText, -moz-Menu), and with no
-   declared scheme the chrome computes those LIGHT — near-black text on the
-   dark background forced above, readable only on hover where the menu
-   switches to SelectedItemText. The palette generator only ever runs `dark`
-   (settings/theming.nix), so the scheme is not conditional. */
+/* Zen's whole palette is built out of light-dark(), which picks its branch
+   from the computed `color-scheme` — not from the colours we set below. So
+   the vars we override here are only half the input: everything Zen derives
+   from them takes the LIGHT branch unless a scheme is declared. Worst case
+   is the menu foreground,
+
+     --zen-colors-primary-foreground: light-dark(
+       var(--zen-branding-bg-reverse),                              // near-black
+       color-mix(in srgb, var(--zen-primary-color) 80%, white 20%)) // light tint
+
+   whose light branch is dark text, landing on the dark backgrounds forced
+   above — invisible until hover swaps in a highlight background. It still
+   tracks the wallpaper (the derived backgrounds move with our accent), which
+   is why switching themes changes how readable it is without ever fixing it.
+   The palette generator only ever runs `dark` (settings/theming.nix), so the
+   scheme is not conditional. */
 :root, menupopup, panel {
   color-scheme: dark !important;
 }